[12.x] Enhancement: the beforeCommit method will now work even if using the ShouldQueueAfterCommit contract

[iz-ahmad]

This PR addresses the issue (#56397). The issue is that when a job is using the ShouldQueueAfterCommit contract it always is dispatched after the commit even when the beforeCommit method is used when dispatching..

DB::transaction(function(){
    $someData = TestModel::create(...);

    JobWithShouldQueueAfterCommitContract::dispatch($someData)->beforeCommit(); // it still is dispatched after the db commit
});

But I guess the `beforeCommit` method should work even when the `ShouldQueueAfterCommit` contract is used, as the purpose of the `beforeCommit` method is to deliberately or especially specify that the **job must be dispatched before commit**.
So, that's why in the `shouldDispatchAfterCommit` method of `Queue.php`, I updated the logic a bit:

if ($job instanceof ShouldQueueAfterCommit) {
    return ! (isset($job->afterCommit) && $job->afterCommit === false); // now it checks the afterCommit flag value
}

Hope, this will enhance the job dispatch behavior and make it better for DX. And yes, I added unit tests in BeforeCommitContractTest.php that checks the relevant cases mostly.


Let me know if any more tests or explanations needed or if I need to modify anything. Thanks.