[12.x] Use getContainer() to avoid fatal error in Pipeline with transactions#56447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
Pipelineclass directly accesses$this->containerwhen running the pipeline within a database transaction:If the container is not set, this causes a fatal error:
This error is unhelpful and makes debugging difficult.
This PR improves the robustness of the
Pipelineby replacing the direct container access with the existinggetContainer()method, which throws a clear and descriptiveRuntimeExceptionif the container is missing:This ensures that users get a meaningful error message:
Additionally, a test was added to verify this behavior when transactions are enabled but no container is set.