[12.x] Cache Singleton/Scoped attribute checks#56633
Merged
taylorotwell merged 6 commits intoAug 13, 2025
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
cosmastech
force-pushed
the
cache-container-attribute-checks
branch
from
2f59a36 to
88bdd73
Compare
cosmastech
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the container is building a class, we perform reflection to check if the class has
#[Scoped]or#[Singleton]attributes. This is unnecessary to check more than once on a particular class.This keeps a memo of the class-string to the outcome of the
Container@getScopedTyped()call. This is similar to how we keep a cache of classes we have checked for#[Bind]attributes.I would normally reach for an enum here but did not because they aren't particularly common in the framework. 🤷