[12.x] Remove leftover method_exists checks#56821
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once upon a time, in the distant land of Laravel 5.1, the
Illuminate\Auth\AuthManagerclass still extended theIlluminate\Support\Managerclass and had a common entry point to create drivers:framework/src/Illuminate/Auth/AuthManager.php
Lines 16 to 36 in 7b586da
As a generic entry point for an arbitrary
Guard, themethod_existschecks were necessary to properly configure a guard instance.Many refactorings came, and the
Illuminate\Auth\AuthManagerevolved to a thing of its own, but themethod_existschecks remained as a leftover from that distant past and ended up on a different methodcreateSessionDriver()that does not create a generic instance anymore.As we now create a concrete class, we know by fact which methods it has and don't need to check for their existence anymore.
This PR:
method_exists()checks from theIlluminate\Auth\AuthManager@createSessionDriver()method