[12.x] Fix exception frame file path on Windows#57103
Merged
Merged
Conversation
avosalmon
changed the title
tegos
pushed a commit
to tegos/laravel-framework
that referenced
this pull request
Sep 28, 2025
* Replace forward slash with DIRECTORY_SEPARATOR * Use join_paths helper * Add unit tests for Frame class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues on the local exception page on Windows.
On Windows, vendor frames are incorrectly identified as non-vendor frames, preventing them from being properly collapsed in the trace.
On windows, frame file paths display absolute path instead of relative path from the base path.
Solution
Replace the hardcoded forward slash with
DIRECTORY_SEPARATORto ensure proper cross-platform compatibility.Related issue
#57082 (comment)