[12.x] HTTP Client: add mergeUrlParameters() to combine URL parameters without overwriting#57282
Merged
Conversation
Add method to merge URL parameters into existing map.
Member
|
I kinda think they should just always merge. |
|
It looks like that the MR title doesn't quite match the final code. There is no new method mergeUrlParameters; instead, the behavior of withUrlParameters was updated to merge (instead of replace). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
mergeUrlParameters(array $parameters = [])toIlluminate\Http\Client\PendingRequest.Today,
withUrlParameters()replaces the entire parameter map, which makes it hard to define global parameters (e.g., in a macro) and then add/override endpoint-specific parameters later. The new method merges into the existing map, letting later calls override only the keys they provide.Backwards compatibility
Usage example