Fix return type order in view function signature#57304
Merged
Merged
Conversation
in return documentation order is factory then ViewContract and IDE is showin diferent order this is so confusing when hower over the method
There was a problem hiding this comment.
Pull Request Overview
Fixes the order of return types in the view() function signature to match the documentation order. The return type annotation was changed from ViewContract|ViewFactory to ViewFactory|ViewContract to align with the PHPDoc comment that specifies factory first, then ViewContract.
- Reordered union types in function signature to match documentation order
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
Does this happen in every IDE or is this an IDE-specific thing? |
Contributor
Author
Contributor
|
"Fixing" is a bit of a strong word for something that isn't "broken", just not that easy on the eye for some that look closely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



in return documentation order is factory, then ViewContract and IDE is showing diferent order, this is so confusing when hower over the method