[12.x] Fix setting request exception truncating doesn't work on HTTP layer when configured inside bootstrap/app.php

[crynobone]

fix #57601

ApplicationBuilder::withExceptions($using) method only resolves the $using callback after resolving Illuminate\Foundation\Exceptions\Handler. Therefore, any value set via new RequestException($response) will only consist of resolved prepareMessage() value before Handler.

Using report() method will solve the issue.

After the changes

Default

Using $exceptions->truncateRequestExceptionsAt(5);

Using $exceptions->dontTruncateRequestExceptions();

[cosmastech]

This broke a test in our pipeline because the exception message changed.

function demo() {
    try {
        Http::throw()->get('https://laravel.com/does-not-exist');
    } catch (Throwable $e) {
        throw new LaravelWebsiteException($e->getMessage(), previous: $e);
    }
}

//
public function testThisThingFails() {
    try {
        demo();
    } catch (LaravelWebsiteException $e) {
        $this->assertStringContainsString('Laravel', $e->getMessage()); // This fails because the message is just: "HTTP request returned status code 404"
    }
}

Not sure about how much monitoring our product has around these errors in DataDog, but it's probably a BC.

[sebastiaanluca]

I agree this seems like a minor breaking change. Our test suite caught it too, the exception message does not contain the summary anymore (the report method is never called).

        Http::fake(['https://api.test' => Http::response($this->getErrorResponse(), SymfonyResponse::HTTP_UNAUTHORIZED)]);

        $this->expectException(RequestException::class);
        $this->expectExceptionCode(SymfonyResponse::HTTP_UNAUTHORIZED);
        $this->expectExceptionMessageMatches($this->getErrorResponse()); // Fails here

Failed asserting that exception message 'HTTP request returned status code 401' matches '{
    "success": false,
    "message": "Something happened"
}
'.