[12.x] optimize AbstractRouteCollection@matchAgainstRoute()#57871
Merged
taylorotwell merged 2 commits intoNov 23, 2025
Conversation
akyrey
pushed a commit
to akyrey/framework
that referenced
this pull request
Dec 29, 2025
…l#57871) * optimize matchAgainstRoute * Add fallback route handling in route matching --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
SanderMuller
added a commit
to SanderMuller/framework
that referenced
this pull request
Mar 15, 2026
…tion() getByAction() wraps the entire attributes array in a Collection just to call first() with a filter closure. This allocates a Collection object unnecessarily when a plain foreach with early return achieves the same result. This follows the same pattern applied to matchAgainstRoutes() in PR laravel#57871, which replaced Collection::first() with foreach for the same reason.
SanderMuller
added a commit
to SanderMuller/framework
that referenced
this pull request
Mar 19, 2026
…tion() getByAction() wraps the entire attributes array in a Collection just to call first() with a filter closure. This allocates a Collection object unnecessarily when a plain foreach with early return achieves the same result. This follows the same pattern applied to matchAgainstRoutes() in PR laravel#57871, which replaced Collection::first() with foreach for the same reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep a pointer to the first matching fallback route, but only loop through the routes once.