Add whenTableHasIndex and whenTableDoesntHaveIndex to Builder#58005
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Member
|
Type should be the last arg imo. |
Contributor
Author
|
@taylorotwell Should be good now, thank you for your review 🫡 |
akyrey
pushed a commit
to akyrey/framework
that referenced
this pull request
Dec 29, 2025
…l#58005) * Update Builder.php * apply big T feedback * fix cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reached for these but only found the
whenTableHasColumnonesThis PR adds
whenTableHasIndexandwhenTableDoesntHaveIndexto align withwhenTableHasColumn.Not sure if you're keen on these, but thought i'd give it a go to help dx
I don't see any tests for
whenTableHasColumn- so have left these out for now. Let me know if you want some tests? I can have a go later on.Before you'd have to use the Schema again:
Now you can just do the below: