[12.x] Fix null array key deprecation in HasOneOrMany relation matching#58191
Merged
taylorotwell merged 1 commit intoDec 22, 2025
Conversation
When a model has a null local key value, the match() method would use null as an array offset in isset($dictionary[$key]), which: 1. Triggers a deprecation warning in PHP 8.5+ 2. Incorrectly matches records with empty string foreign keys due to PHP's implicit null-to-empty-string conversion This fix explicitly checks for null before accessing the dictionary, ensuring models with null local keys don't receive any related records. Fixes #58151
akyrey
pushed a commit
to akyrey/framework
that referenced
this pull request
Dec 29, 2025
…aravel#58191) When a model has a null local key value, the match() method would use null as an array offset in isset($dictionary[$key]), which: 1. Triggers a deprecation warning in PHP 8.5+ 2. Incorrectly matches records with empty string foreign keys due to PHP's implicit null-to-empty-string conversion This fix explicitly checks for null before accessing the dictionary, ensuring models with null local keys don't receive any related records. Fixes laravel#58151 Co-authored-by: S. Bondarenko <s.bondarenko@mayabproject.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the PHP 8.5+ deprecation warning "Using null as an array offset is deprecated" in
HasOneOrMany,HasManyThrough, andHasOneThroughrelations.More importantly, it fixes a behavioral bug: models with
nulllocal key values were incorrectly matching records with empty string ('') foreign keys due to PHP's implicitnull→''conversion.Problem