[12.x] Resolve infinite loop when using deferred queue#58373
Merged
Conversation
abkarino
reviewed
Jan 14, 2026
|
|
||
| $this->app['events']->listen(function (JobAttempted $event) { | ||
| app(DeferredCallbackCollection::class)->invokeWhen(fn ($callback) => $event->connectionName !== 'sync' && ($event->successful() || $callback->always)); | ||
| app(DeferredCallbackCollection::class)->invokeWhen(static fn ($callback) => ! in_array($event->connectionName, ['sync', 'deferred']) && ($event->successful() || $callback->always)); |
There was a problem hiding this comment.
Shouldn't the comparison be strict i.e. passing true?
I don't know the code practices in here, but I believe for two values, two checks is faster than in_array. Though the difference would be minimal but the two conditions will support short circuiting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To close #58351
Tested this locally. As described in the issue, this spawns an infinite loop. After this change, the job is executed and no infinite loop.