[12.x] Annotate tuple return type of Number::pairs()#58409
Merged
taylorotwell merged 1 commit intoJan 19, 2026
Conversation
Improved the return type from generic `array` to `list<array{int|float, int|float}>` which accurately describes that the method returns a list of two-element tuples containing the lower and upper bounds.
This improves:
- Static analysis accuracy
- IDE type inference
- Developer experience with better autocompletion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the return type annotation for
Number::pairs()from genericarraytolist<array{int|float, int|float}>.The method returns a list of two-element arrays where each array contains the lower and upper bounds of a range. The new type annotation accurately describes this structure.
Benefits:
Similar to #58354 which annotated tuple return types for
TableGuesser::guess().