[12.x] Improve migration types

[shaedrich]

Benefits

✅ Improved static analysis
✅ Improved type inference
✅ Increased type coverage

Highlights

• Closures with argument and return types
• Union string literals where possible
• Array and object shapes
• Class string
• Narrowed integers

[shaedrich]

Test failures seem to be unrelated to the changes of this PR (the static analysis error will be fixed with #58562)

[rforced]

@shaedrich I'm now seeing this error when running larastan after this upgrade. Any ideas?

---

Line database/migrations/2022_06_13_191522_create_team_user_table.php

---

15 Call to an undefined method Illuminate\Database\Schema\ForeignKeyDefinition::onDelete().
🪪 method.notFound
16 Call to an undefined method Illuminate\Database\Schema\ForeignKeyDefinition::onDelete().
🪪 method.notFound

---

[shaedrich]

@rforced Thanks for reporting this! 👍🏻

Looked good to me at first, but turns out, @method type annotations are a little more fragile than others 😅

And sorry for the inconvenience 😬

[jackbayliss]

@shaedrich Good day sir!

The lock stuff here is making my PHPstorm not show whats allowed

I thought i'd @ you cause I'm sure you have the answer for it :D its probably fine but I found it weird :)