[12.x] brick/math of float deprecation

[jackbayliss]

Seeing this in CI, which is killing tests:

Passing floats to BigNumber::of() and arithmetic methods is deprecated and will be removed in 0.15. Cast the float to string explicitly to preserve the previous behaviour.

Passing float values to of() or arithmetic methods is deprecated in brick/math 0.14.2

This basically handles the float types and casts it to a string as suggested. All of the changes are basically within the ValidatesAttributes trait.

I don't think it's a B/C as it's just ensuring the current output / internal methods and all tests seem to pass.

Feel free to close / adjust as you see fit- figured I'd throw up a PR up as it was annoying me.

[github-actions]

Thanks for submitting a PR!

Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[jackbayliss]

Only failing test here now is the static analysis one, which is addressed in #58562

Thanks!

[paweljar]

Did you forget about fixing the validateMin and validateMax rules? Both use BigNumber::of, which can get the float type and causes the warning.

[jackbayliss]

@paweljar getSize is called inside the of() for both of those which shouldn't return a float hence the return type.

Unless there's some methods I missed? Or I'm missing something which is possible 😂

[paweljar]

@jackbayliss Thanks for the explanation! I see, and just double-checked it locally, the line below is the key and it fixes all other rules as well.

Clear, waiting for the release :)