Skip to content

[12.x] Fix TwoColumnDetail stripping trailing punctuation from second column values#59010

Merged
taylorotwell merged 1 commit into
laravel:12.xfrom
theritvars:fix/two-column-detail-strip-trailing-punctuation
Feb 26, 2026
Merged

[12.x] Fix TwoColumnDetail stripping trailing punctuation from second column values#59010
taylorotwell merged 1 commit into
laravel:12.xfrom
theritvars:fix/two-column-detail-strip-trailing-punctuation

Conversation

@theritvars

Copy link
Copy Markdown
Contributor

Problem

TwoColumnDetail applies the EnsureNoPunctuation mutator to both columns, but it should only apply to the first. The second column holds data values, not labels, so stripping trailing punctuation (., ?, !, :) from it is wrong.

In practice, this means php artisan config:show silently truncates config values — "Welcome to Laravel!" displays as "Welcome to Laravel".

Fix

Remove EnsureNoPunctuation from the second column's mutator list.

I checked every TwoColumnDetail callsite in the framework (AboutCommand, ConfigShowCommand, ShowModelCommand, TableCommand, ShowCommand, StatusCommand, ListFailedCommand, VendorPublishCommand, EnvironmentEncryptCommand, EnvironmentDecryptCommand, both MonitorCommand variants). None of them were relying on punctuation being stripped from the second column — if anything, a few of them (config values, SQL table comments) were having user data quietly mangled.

@theritvars theritvars changed the title Fix TwoColumnDetail stripping trailing punctuation from second column values [12.x] Fix TwoColumnDetail stripping trailing punctuation from second column values Feb 26, 2026
@taylorotwell taylorotwell merged commit 81518e8 into laravel:12.x Feb 26, 2026
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants