[12.x] Fix TwoColumnDetail stripping trailing punctuation from second column values#59010
Merged
taylorotwell merged 1 commit intoFeb 26, 2026
Merged
[12.x] Fix TwoColumnDetail stripping trailing punctuation from second column values#59010taylorotwell merged 1 commit into
taylorotwell merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TwoColumnDetailapplies theEnsureNoPunctuationmutator to both columns, but it should only apply to the first. The second column holds data values, not labels, so stripping trailing punctuation (.,?,!,:) from it is wrong.In practice, this means
php artisan config:showsilently truncates config values —"Welcome to Laravel!"displays as"Welcome to Laravel".Fix
Remove
EnsureNoPunctuationfrom the second column's mutator list.I checked every
TwoColumnDetailcallsite in the framework (AboutCommand,ConfigShowCommand,ShowModelCommand,TableCommand,ShowCommand,StatusCommand,ListFailedCommand,VendorPublishCommand,EnvironmentEncryptCommand,EnvironmentDecryptCommand, bothMonitorCommandvariants). None of them were relying on punctuation being stripped from the second column — if anything, a few of them (config values, SQL table comments) were having user data quietly mangled.