Skip to content

feat: Add new recognizer for IN_VOTER #1344#1345

Merged
omri374 merged 13 commits into
microsoft:mainfrom
kjdeveloper8:main
Apr 16, 2024
Merged

feat: Add new recognizer for IN_VOTER #1344#1345
omri374 merged 13 commits into
microsoft:mainfrom
kjdeveloper8:main

Conversation

@kjdeveloper8

Copy link
Copy Markdown
Contributor

Change Description

  • Add new reconizer IN_VOTER with regex
  • Added test module for the same

Issue reference

This PR fixes issue #1344

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests and linting
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@kjdeveloper8

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Comment thread presidio-analyzer/presidio_analyzer/predefined_recognizers/in_voter_recognizer.py Outdated
Comment thread presidio-analyzer/presidio_analyzer/predefined_recognizers/in_voter_recognizer.py Outdated
@omri374

omri374 commented Mar 28, 2024

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread presidio-analyzer/presidio_analyzer/predefined_recognizers/in_voter_recognizer.py Outdated
@omri374

omri374 commented Mar 30, 2024

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@omri374

omri374 commented Mar 30, 2024

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

SharonHart
SharonHart previously approved these changes Mar 31, 2024

@SharonHart SharonHart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved considering Omri's comment on reducing the base score

@kjdeveloper8

Copy link
Copy Markdown
Contributor Author

@omri374 thank you for your time to reviewing this, i have updated the changes accordingly as per your suggestions

omri374
omri374 previously approved these changes Apr 1, 2024

@omri374 omri374 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omri374

omri374 commented Apr 1, 2024

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

SharonHart
SharonHart previously approved these changes Apr 2, 2024

@SharonHart SharonHart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@omri374 omri374 dismissed stale reviews from SharonHart and themself via c41a93a April 11, 2024 19:12
@omri374

omri374 commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@omri374

omri374 commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

@kjdeveloper8 the CI is failing due to a test counting the number of predefined recognizers. Can you please update it?

@kjdeveloper8

Copy link
Copy Markdown
Contributor Author

updated

@omri374

omri374 commented Apr 15, 2024

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@omri374

omri374 commented Apr 15, 2024

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit 41e0202 into microsoft:main Apr 16, 2024
@omri374

omri374 commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator

Thanks! Merged

prokopidis pushed a commit to prokopidis/presidio that referenced this pull request Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants