NLP engine sample + refresh on samples#1388
Merged
Merged
Conversation
* initial version of loader * addressed comments * linting fixes * re structured recognizers in yaml * addressed comments and fixed predefined recognizers loading * added engine provider to analyzer init * moved logic to recognizer registry provider * some name fixes to recognizer provider * added language support to recognizer registry * fixed interface issues, added unit tests for providers * fixed tests, addressed comments * added yaml configuration to package, fixed linting rules * move all conf file to a single location * remove file from previous location * merged from main, added default conf file for engine provider * addressed some comments * setup fixups * remove redundant line * fix long line * fixing linting errors * Update presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py Co-authored-by: Sharon Hart <sharonh.dev@gmail.com> * updates to the existing logic for loading engines through configuration * updates to Dockerfile --------- Co-authored-by: roeybc <robencha@microsoft.com> Co-authored-by: Sharon Hart <sharonh.dev@gmail.com>
…feature/engines_from_conf # Conflicts: # presidio-analyzer/setup.py
SharonHart
reviewed
Jul 10, 2024
SharonHart
reviewed
Jul 10, 2024
SharonHart
previously approved these changes
Jul 10, 2024
SharonHart
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates for samples and docs