Skip to content

Fix return type annotation of verify_dicom_instance function#1547

Merged
SharonHart merged 1 commit into
microsoft:mainfrom
siwoo-jung:fix_incorrect_return_type-verify_dicom_instance
Mar 10, 2025
Merged

Fix return type annotation of verify_dicom_instance function#1547
SharonHart merged 1 commit into
microsoft:mainfrom
siwoo-jung:fix_incorrect_return_type-verify_dicom_instance

Conversation

@siwoo-jung

@siwoo-jung siwoo-jung commented Mar 9, 2025

Copy link
Copy Markdown
Contributor

Change Description

This PR corrects the type annotation for the ocr_bboxes return value in the verify_dicom_instance function. The original annotation indicated that ocr_bboxes would be of type dict, but the actual output is a list. Therefore, this PR updates the return type annotation to reflect the correct type of ocr_bboxes as a list.

Issue reference

This PR fixes issue #1548

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@siwoo-jung

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@omri374

omri374 commented Mar 10, 2025

Copy link
Copy Markdown
Collaborator

/azp run

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR corrects the return type annotation for the ocr_bboxes value in the verify_dicom_instance function to accurately reflect that it is a list rather than a dict.

  • The changelog has been updated to document the return type change.
  • The function signature in dicom_image_pii_verify_engine.py has been adjusted to return a Tuple with the second element as a list.

Reviewed Changes

File Description
CHANGELOG.md Updated changelog entry to reflect the return type annotation change.
presidio-image-redactor/presidio_image_redactor/dicom_image_pii_verify_engine.py Modified the function signature to change ocr_bboxes from dict to list.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omri374

omri374 commented Mar 10, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart SharonHart merged commit 6b10fd5 into microsoft:main Mar 10, 2025
prokopidis pushed a commit to prokopidis/presidio that referenced this pull request Jun 23, 2026
…t#1547)

Co-authored-by: Siwoo Jung <siwoojung@Siwoos-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants