Fix return type annotation of verify_dicom_instance function#1547
Merged
SharonHart merged 1 commit intoMar 10, 2025
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
/azp run |
Contributor
There was a problem hiding this comment.
PR Overview
This PR corrects the return type annotation for the ocr_bboxes value in the verify_dicom_instance function to accurately reflect that it is a list rather than a dict.
- The changelog has been updated to document the return type change.
- The function signature in dicom_image_pii_verify_engine.py has been adjusted to return a Tuple with the second element as a list.
Reviewed Changes
| File | Description |
|---|---|
| CHANGELOG.md | Updated changelog entry to reflect the return type annotation change. |
| presidio-image-redactor/presidio_image_redactor/dicom_image_pii_verify_engine.py | Modified the function signature to change ocr_bboxes from dict to list. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SharonHart
approved these changes
Mar 10, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prokopidis
pushed a commit
to prokopidis/presidio
that referenced
this pull request
Jun 23, 2026
…t#1547) Co-authored-by: Siwoo Jung <siwoojung@Siwoos-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
This PR corrects the type annotation for the
ocr_bboxesreturn value in theverify_dicom_instancefunction. The original annotation indicated that ocr_bboxes would be of type dict, but the actual output is a list. Therefore, this PR updates the return type annotation to reflect the correct type of ocr_bboxes as a list.Issue reference
This PR fixes issue #1548
Checklist