Skip to content

Option to create recognizers in YAML#849

Merged
omri374 merged 9 commits into
mainfrom
omri/recognizers_yml
Apr 27, 2022
Merged

Option to create recognizers in YAML#849
omri374 merged 9 commits into
mainfrom
omri/recognizers_yml

Conversation

@omri374

@omri374 omri374 commented Apr 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Change Description

Added methods to the RecognizerRegistry which allow recognizers to be loaded from a dict and a yaml file.

Issue reference

This PR fixes issue #855

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@omri374

omri374 commented Apr 5, 2022

Copy link
Copy Markdown
Collaborator Author

@ontocord and @paulovn added the option of loading recognizers via YAML

shiranr
shiranr reviewed Apr 24, 2022
View reviewed changes
Comment thread docs/analyzer/adding_recognizers.md Outdated
Comment thread docs/analyzer/adding_recognizers.md Outdated
Comment thread presidio-analyzer/presidio_analyzer/recognizer_registry/recognizer_registry.py
Comment thread presidio-analyzer/tests/conf/recognizers.yaml
itye-msft
itye-msft previously approved these changes Apr 24, 2022
View reviewed changes

@itye-msft itye-msft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments for your consideration

Comment thread presidio-analyzer/presidio_analyzer/recognizer_registry/recognizer_registry.py Outdated
Comment thread presidio-analyzer/presidio_analyzer/recognizer_registry/recognizer_registry.py Outdated
Comment thread presidio-analyzer/tests/test_recognizer_registry.py
shiranr
shiranr previously approved these changes Apr 24, 2022
View reviewed changes
@omri374

omri374 commented Apr 24, 2022

Copy link
Copy Markdown
Collaborator Author

@shiranr thanks for your feedback! I agree that having the same example file in 10 different places isn't probably the perfect solution 😊. Let me see if I can create some references and I'll update the PR.

@omri374 omri374 dismissed stale reviews from shiranr and itye-msft via be8689b April 25, 2022 20:42
@omri374 omri374 requested review from itye-msft and shiranr April 26, 2022 18:12
@omri374 omri374 linked an issue Apr 27, 2022 that may be closed by this pull request
Introduce pattern recognizers from file #855
Closed
@omri374

omri374 commented Apr 27, 2022

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Apr 27, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit 444f61c into main Apr 27, 2022
@omri374 omri374 deleted the omri/recognizers_yml branch April 27, 2022 09:21
prokopidis pushed a commit to prokopidis/presidio that referenced this pull request Jun 23, 2026
@omri374
Option to create recognizers in YAML (microsoft#849)
9b91935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shiranr shiranr shiranr approved these changes
@itye-msft itye-msft itye-msft approved these changes
@SharonHart SharonHart Awaiting requested review from SharonHart
@navalev navalev Awaiting requested review from navalev
@balteravishay balteravishay Awaiting requested review from balteravishay
@guybartal guybartal Awaiting requested review from guybartal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce pattern recognizers from file

3 participants

@omri374 @shiranr @itye-msft