Remove debugger banner#19849
Merged
karthiknadig merged 2 commits intoOct 12, 2022
Merged
Conversation
|
|
karthiknadig
approved these changes
Sep 16, 2022
Member
|
@farahtk can you click the sign button here to accept our Contributor License Agreement? 😄 |
Author
|
@luabud waiting for my company to review and approve :) |
Member
Member
|
@farahtk Any update on the CLA? |
Author
@karthiknadig got the approval to move forward |
Member
|
@farahtk I will close and re-open this issue to re-trigger CLA bot. Please sign the CLA, then we can continue to merge. |
Author
|
@microsoft-github-policy-service agree |
karrtikr
approved these changes
Oct 12, 2022
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
### Problem #### Issue Link microsoft/vscode-python#19714 #### Summary Remove debugger banner #### Description It was reported in the issue 19714 that we display a prompt to get feedback on a separate survey for the debugger, but given we get a lot of feedback for the debugger in our "general" survey, it should be fine to remove it. ### Solution #### Implementation The current implementation of the debugger survey is defined in a banner class. This class pops up a banner to ask if the user wants to fill out the survey or not. If selected yes, a browser with the survey link is opened. After discussing with the team, we decided to remove the banner completely, and if it is needed in the future the team will restore it. #### Testing ##### Unit test [debugging-output.txt](https://github.com/microsoft/vscode-python/files/9586036/debugging-output.txt)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue Link
#19714
Summary
Remove debugger banner
Description
It was reported in the issue 19714 that we display a prompt to get feedback on a separate survey for the debugger, but given we get a lot of feedback for the debugger in our "general" survey, it should be fine to remove it.
Solution
Implementation
The current implementation of the debugger survey is defined in a banner class. This class pops up a banner to ask if the user wants to fill out the survey or not. If selected yes, a browser with the survey link is opened.
After discussing with the team, we decided to remove the banner completely, and if it is needed in the future the team will restore it.
Testing
Unit test
debugging-output.txt