Skip to content

feat: truncate patch on verifier version#1629

Merged
HrikB merged 3 commits into
mainfrom
feat/truncate-patch
May 8, 2025
Merged

feat: truncate patch on verifier version#1629
HrikB merged 3 commits into
mainfrom
feat/truncate-patch

Conversation

@HrikB

@HrikB HrikB commented May 6, 2025

Copy link
Copy Markdown
Contributor

Truncates the patch version from halo2 verifier.

Also bumps the openvm version to 1.1.2

@HrikB HrikB force-pushed the feat/truncate-patch branch from c9caf8e to bf45997 Compare May 6, 2025 20:20
@github-actions

This comment has been minimized.

@HrikB HrikB force-pushed the feat/truncate-patch branch from bf45997 to 959bc8a Compare May 6, 2025 21:02
@github-actions

This comment has been minimized.

@HrikB HrikB force-pushed the feat/truncate-patch branch from 959bc8a to 0144e4b Compare May 6, 2025 21:13
@github-actions

This comment has been minimized.

@HrikB HrikB force-pushed the feat/truncate-patch branch from 0144e4b to c0d97c9 Compare May 6, 2025 23:29
@github-actions

This comment has been minimized.

@HrikB HrikB force-pushed the feat/truncate-patch branch from c0d97c9 to 9e1dd3a Compare May 6, 2025 23:39
@github-actions

github-actions Bot commented May 6, 2025

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-62 [-5.2%]) 1,140 334,067 17,676,398 - - -
fibonacci (-39 [-1.5%]) 2,479 1,500,277 50,589,503 - - -
regex (-45 [-0.6%]) 7,452 4,165,226 166,511,152 - - -
ecrecover (+8 [+0.6%]) 1,413 289,447 14,470,186 - - -
pairing 4,484 1,820,436 95,832,407 - - -

Commit: 9e1dd3a

Benchmark Workflow

@HrikB HrikB marked this pull request as ready for review May 7, 2025 16:00
@HrikB HrikB requested review from jonathanpwang and yi-sun May 7, 2025 16:00
Comment thread crates/sdk/src/lib.rs
pub const EVM_HALO2_VERIFIER_TEMPLATE: &str =
include_str!("../contracts/template/OpenVmHalo2Verifier.sol");
pub const OPENVM_VERSION: &str = concat!(
env!("CARGO_PKG_VERSION_MAJOR"),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice, didn't know this existed!

@jonathanpwang jonathanpwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HrikB HrikB merged commit f0477ab into main May 8, 2025
@HrikB HrikB deleted the feat/truncate-patch branch May 8, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants