Skip to content

fix(new-execution): return segments in execute_metered#1702

Merged
shuklaayush merged 2 commits into
feat/new-executionfrom
feat/new-exec-e2-return-segments
Jun 2, 2025
Merged

fix(new-execution): return segments in execute_metered#1702
shuklaayush merged 2 commits into
feat/new-executionfrom
feat/new-exec-e2-return-segments

Conversation

@shuklaayush

@shuklaayush shuklaayush commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator
  • also increased the max trace cells threshold to 2bn for now

@shuklaayush shuklaayush requested a review from nyunyunyunyu June 2, 2025 18:43
@codspeed-hq

codspeed-hq Bot commented Jun 2, 2025

Copy link
Copy Markdown

CodSpeed Walltime Performance Report

Merging #1702 will not alter performance

Comparing feat/new-exec-e2-return-segments (6ca9110) with feat/new-execution (a7f81dc)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 10 untouched benchmarks

@shuklaayush shuklaayush merged commit 82f7ff9 into feat/new-execution Jun 2, 2025
25 of 27 checks passed
@shuklaayush shuklaayush deleted the feat/new-exec-e2-return-segments branch June 2, 2025 18:47
@github-actions

github-actions Bot commented Jun 2, 2025

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-125 [-10.5%]) 1,062 334,008 17,675,804 - - -
fibonacci (-371 [-14.8%]) 2,139 1,500,277 50,589,503 - - -
regex (-329 [-4.5%]) 7,036 4,165,432 166,519,456 - - -
ecrecover (+16 [+1.2%]) 1,405 289,547 (+43030 [+0.3%]) 14,513,216 - - -
pairing (-70 [-1.6%]) 4,427 1,820,436 (+346586 [+0.4%]) 96,178,993 - - -

Commit: 6ca9110

Benchmark Workflow

@codspeed-hq

codspeed-hq Bot commented Jun 2, 2025

Copy link
Copy Markdown

CodSpeed Instrumentation Performance Report

Merging #1702 will not alter performance

Comparing feat/new-exec-e2-return-segments (6ca9110) with feat/new-execution (a7f81dc)

Summary

✅ 10 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants