refactor: Move Streams into VmStateMut#1707
Conversation
CodSpeed Walltime Performance ReportMerging #1707 will improve performances by 13.62%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | benchmark_execute[factorial_iterative_u256] |
558.6 ms | 506 ms | +10.4% |
| ⚡ | benchmark_execute[fibonacci_iterative] |
560.8 ms | 503.2 ms | +11.45% |
| ⚡ | benchmark_execute[fibonacci_recursive] |
538.8 ms | 482.1 ms | +11.77% |
| ⚡ | benchmark_execute[keccak256] |
566.4 ms | 498.5 ms | +13.62% |
| ⚡ | benchmark_execute[keccak256_iter] |
560.9 ms | 500.4 ms | +12.08% |
| ⚡ | benchmark_execute[quicksort] |
562.1 ms | 508.9 ms | +10.47% |
| ⚡ | benchmark_execute[sha256] |
559.2 ms | 500.5 ms | +11.74% |
| ⚡ | benchmark_execute[sha256_iter] |
538.6 ms | 489.1 ms | +10.11% |
465d6fa to
06bc3c3
Compare
CodSpeed Instrumentation Performance ReportMerging #1707 will not alter performanceComparing Summary
|
06bc3c3 to
257ddb3
Compare
Commit: 257ddb3 |
|
To check, the logic to move into |
Yes, it's not specific to any execution mode |
jonathanpwang
left a comment
There was a problem hiding this comment.
LGTM except I don't understand why the metrics thing changed
Previously some chips hold
Arc<Mutex<Streams>>to read fromStreams. MoveStreamsintoVmStateMutso it has all data about VM state.