Skip to content

chore: add serde to segment#1749

Merged
jonathanpwang merged 1 commit into
feat/new-executionfrom
lunkai/segment-serde
Jun 17, 2025
Merged

chore: add serde to segment#1749
jonathanpwang merged 1 commit into
feat/new-executionfrom
lunkai/segment-serde

Conversation

@luffykai

Copy link
Copy Markdown
Contributor

No description provided.

@luffykai luffykai requested a review from shuklaayush June 17, 2025 04:22
@codspeed-hq

codspeed-hq Bot commented Jun 17, 2025

Copy link
Copy Markdown

CodSpeed Walltime Performance Report

Merging #1749 will not alter performance

Comparing lunkai/segment-serde (2f72f9f) with feat/new-execution (9364d65)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 10 untouched benchmarks

@github-actions

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-185 [-14.8%]) 1,066 322,773 17,341,042 - - -
fibonacci (-458 [-17.3%]) 2,197 1,500,277 50,589,503 - - -
regex (-1223 [-15.6%]) 6,633 4,165,432 166,519,456 - - -
ecrecover (+179 [+15.6%]) 1,327 (-14218 [-10.4%]) 122,000 (-548071 [-6.8%]) 7,542,191 - - -
pairing (+28 [+0.6%]) 4,494 1,862,964 (+230956 [+0.2%]) 97,508,739 - - -

Commit: 2f72f9f

Benchmark Workflow

@codspeed-hq

codspeed-hq Bot commented Jun 17, 2025

Copy link
Copy Markdown

CodSpeed Instrumentation Performance Report

Merging #1749 will not alter performance

Comparing lunkai/segment-serde (2f72f9f) with feat/new-execution (9364d65)

Summary

✅ 10 untouched benchmarks

@jonathanpwang

Copy link
Copy Markdown
Contributor

note: we may want to just write a custom serializer to bytes

@jonathanpwang jonathanpwang merged commit e8ded6c into feat/new-execution Jun 17, 2025
34 of 35 checks passed
@jonathanpwang jonathanpwang deleted the lunkai/segment-serde branch June 17, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants