chore: add execution insn/s logging#1764
Merged
Merged
Conversation
- Add support for execute_e1, execute_metered, and execute_e3 metrics - Update par_proof_time calculation to use execute_metered_time_ms directly - Display execute_metered metrics with only sum values (dashes in avg/max/min) - Replace all execute_e2 references with execute_metered to match naming convention
- Make get_single_summary resilient to missing total_proof_time_ms metric - Compute proof time from trace_gen + stark_prove if total metric not available - Update benchmark workflow to compare against target branch instead of main for PRs - Use full SHA from target branch for metric comparison
CodSpeed WallTime Performance ReportMerging #1764 will not alter performanceComparing
|
This comment has been minimized.
This comment has been minimized.
CodSpeed Instrumentation Performance ReportMerging #1764 will not alter performanceComparing Summary
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: 58595f0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently do not run e1 in the local (single machine) proving flow. We will update openvm-prof once that is added.
Due to the limited nature of the metric aggregation by segment,
total_proof_time_msincludes the e2(metered) time for single segments (all aggregation proofs) but excludes it for app proofs. I include the app e2 time in the final totals.Updates the metrics caching and PR comment so that it will compare using the PR's target branch as base.
Example run: https://github.com/openvm-org/openvm/blob/benchmark-results/benchmarks-pr/1764/regex-f073953995b8735d92bf3a91b452e3047cb1d671.md