Skip to content

fix: proper memory access functions in execute_e1_impl in the native poseidon chip#1790

Merged
jonathanpwang merged 1 commit into
feat/new-executionfrom
fix/poseidon-e2
Jun 25, 2025
Merged

fix: proper memory access functions in execute_e1_impl in the native poseidon chip#1790
jonathanpwang merged 1 commit into
feat/new-executionfrom
fix/poseidon-e2

Conversation

@Golovanov399

Copy link
Copy Markdown
Contributor

Otherwise memory is not metered properly

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2025

Copy link
Copy Markdown

CodSpeed WallTime Performance Report

Merging #1790 will not alter performance

Comparing fix/poseidon-e2 (7b62f51) with feat/new-execution (184b12e)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 20 untouched benchmarks

@github-actions

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+6 [+0.4%]) 1,466 322,699 17,340,154 - - -
fibonacci (-34 [-1.3%]) 2,631 1,500,277 50,589,503 - - -
regex (-81 [-1.1%]) 7,398 4,165,432 166,519,456 - - -
ecrecover (-61 [-3.6%]) 1,644 137,260 8,150,689 - - -
pairing 4,295 1,862,964 97,508,739 - - -

Commit: 7b62f51

Benchmark Workflow

@jonathanpwang jonathanpwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish for the day we can remove this memory_read_native_from_state function

@jonathanpwang jonathanpwang merged commit ca2e67d into feat/new-execution Jun 25, 2025
36 of 37 checks passed
@jonathanpwang jonathanpwang deleted the fix/poseidon-e2 branch June 25, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants