fix: proper memory access functions in execute_e1_impl in the native poseidon chip#1790
Merged
Merged
Conversation
CodSpeed WallTime Performance ReportMerging #1790 will not alter performanceComparing
|
Commit: 7b62f51 |
jonathanpwang
approved these changes
Jun 25, 2025
jonathanpwang
left a comment
Contributor
There was a problem hiding this comment.
I wish for the day we can remove this memory_read_native_from_state function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise memory is not metered properly