refactor(new-execution): optimize E1/E2 implementation#1827
Merged
Conversation
- implemented e1 for all native chips - added a `test_vm_e1_native_chips` that does e1 execution for all chips except poseidon2 verify_batch --------- Co-authored-by: Xinding Wei <weixinding@gmail.com>
…1814) - added fn pointer based e1 for algebra/ecc chips
- fixed some execute functions to match the spec. details in comments --------- Co-authored-by: Xinding Wei <weixinding@gmail.com>
CodSpeed WallTime Performance ReportMerging #1827 will improve performances by ×3.8Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | benchmark_execute[bubblesort] |
403.7 ms | 171.5 ms | ×2.4 |
| ⚡ | benchmark_execute[factorial_iterative_u256] |
1,166.2 ms | 307.7 ms | ×3.8 |
| ⚡ | benchmark_execute[fibonacci_iterative] |
464.2 ms | 186.9 ms | ×2.5 |
| ⚡ | benchmark_execute[fibonacci_recursive] |
608.3 ms | 211.2 ms | ×2.9 |
| ⚡ | benchmark_execute[keccak256] |
443.4 ms | 160.6 ms | ×2.8 |
| ⚡ | benchmark_execute[keccak256_iter] |
685.8 ms | 269.7 ms | ×2.5 |
| 🆕 | benchmark_execute[pairing] |
N/A | 421.9 ms | N/A |
| ⚡ | benchmark_execute[quicksort] |
451.6 ms | 164.2 ms | ×2.8 |
| 🆕 | benchmark_execute[revm_transfer] |
N/A | 280.9 ms | N/A |
| ⚡ | benchmark_execute[sha256] |
436.5 ms | 159.7 ms | ×2.7 |
| ⚡ | benchmark_execute[sha256_iter] |
704.6 ms | 251.2 ms | ×2.8 |
| ⚡ | benchmark_execute_metered[bubblesort] |
614.7 ms | 233.6 ms | ×2.6 |
| ⚡ | benchmark_execute_metered[factorial_iterative_u256] |
1,944.5 ms | 563.5 ms | ×3.5 |
| ⚡ | benchmark_execute_metered[fibonacci_iterative] |
675.9 ms | 212.7 ms | ×3.2 |
| ⚡ | benchmark_execute_metered[fibonacci_recursive] |
953 ms | 304.9 ms | ×3.1 |
| ⚡ | benchmark_execute_metered[keccak256] |
699.1 ms | 225.4 ms | ×3.1 |
| ⚡ | benchmark_execute_metered[keccak256_iter] |
1,136.3 ms | 387.4 ms | ×2.9 |
| 🆕 | benchmark_execute_metered[pairing] |
N/A | 458.9 ms | N/A |
| ⚡ | benchmark_execute_metered[quicksort] |
696.7 ms | 238.9 ms | ×2.9 |
| 🆕 | benchmark_execute_metered[revm_transfer] |
N/A | 335.8 ms | N/A |
| ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
…1` (#1823) - make `execute_e1` use interpreter instance
Co-authored-by: Xinding Wei <weixinding@gmail.com>
Co-authored-by: Ayush Shukla <shuklaayush247@gmail.com> Co-authored-by: Ayush Shukla <ayush@axiom.xyz>
shuklaayush
changed the title
| - name: Build benchmarks | ||
| working-directory: benchmarks/execute | ||
| run: cargo codspeed build | ||
| run: cargo codspeed build --profile maxperf |
Contributor
There was a problem hiding this comment.
were we going to revert this?
Contributor
Author
There was a problem hiding this comment.
I think we want to benchmark with maxperf?
This comment has been minimized.
This comment has been minimized.
jonathanpwang
approved these changes
Jul 14, 2025
jonathanpwang
left a comment
jonathanpwang
left a comment
Contributor
There was a problem hiding this comment.
We can merge first to expedite, but please resolve the existing comments
This comment has been minimized.
This comment has been minimized.
shuklaayush
reviewed
Jul 14, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: 0abeb61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.