feat: use cached max trace heights in leaf/internal aggregation#1839
Merged
stephenh-axiom-xyz merged 13 commits intoJul 11, 2025
Conversation
CodSpeed WallTime Performance ReportMerging #1839 will not alter performanceComparing
|
shuklaayush
reviewed
Jul 10, 2025
Collaborator
|
looks okay but some tests seem to be failing |
jonathanpwang
approved these changes
Jul 10, 2025
jonathanpwang
left a comment
Contributor
There was a problem hiding this comment.
LGTM after fixing the sdk bug.
I would have preferred if we deleted E2 from SingleSegmentExecutor directly, but I am rewriting it in feat/new-exec-device anyways so we can hold off
22e9262 to
514d23b
Compare
ac211b7 to
43508b8
Compare
This comment has been minimized.
This comment has been minimized.
shuklaayush
reviewed
Jul 11, 2025
Commit: 022cb4a |
a6be3df
into
feat/new-execution
35 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves INT-4375.
NativeConfigmax trace heights (derived from thekitchen-sinkbenchmark) and uses them during leaf/internal verification.