Skip to content

feat: use cached max trace heights in leaf/internal aggregation#1839

Merged
stephenh-axiom-xyz merged 13 commits into
feat/new-executionfrom
feat/remove-single-segment-e2
Jul 11, 2025
Merged

feat: use cached max trace heights in leaf/internal aggregation#1839
stephenh-axiom-xyz merged 13 commits into
feat/new-executionfrom
feat/remove-single-segment-e2

Conversation

@stephenh-axiom-xyz

Copy link
Copy Markdown
Contributor

Resolves INT-4375.

  • Hardcodes NativeConfig max trace heights (derived from the kitchen-sink benchmark) and uses them during leaf/internal verification.
  • Adds metering to phantom chip, removes metering from public values chip (since estimation is derived from config)

@codspeed-hq

codspeed-hq Bot commented Jul 9, 2025

Copy link
Copy Markdown

CodSpeed WallTime Performance Report

Merging #1839 will not alter performance

Comparing feat/remove-single-segment-e2 (022cb4a) with feat/new-execution (a7d1125)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 20 untouched benchmarks

Comment thread crates/sdk/src/prover/vm/local.rs Outdated
@shuklaayush

Copy link
Copy Markdown
Collaborator

looks okay but some tests seem to be failing

Comment thread benchmarks/prove/src/bin/kitchen_sink.rs Outdated
Comment thread crates/sdk/src/prover/vm/local.rs Outdated

@jonathanpwang jonathanpwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing the sdk bug.

I would have preferred if we deleted E2 from SingleSegmentExecutor directly, but I am rewriting it in feat/new-exec-device anyways so we can hold off

@stephenh-axiom-xyz stephenh-axiom-xyz force-pushed the feat/remove-single-segment-e2 branch 2 times, most recently from 22e9262 to 514d23b Compare July 10, 2025 18:17
@stephenh-axiom-xyz stephenh-axiom-xyz force-pushed the feat/remove-single-segment-e2 branch from ac211b7 to 43508b8 Compare July 11, 2025 15:36
@github-actions

This comment has been minimized.

Comment thread benchmarks/prove/src/bin/kitchen_sink.rs

@shuklaayush shuklaayush left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+14 [+1.1%]) 1,261 322,648 17,270,578 - - -
fibonacci (+40 [+1.7%]) 2,374 1,500,277 50,589,231 3,445 1,248,040 70,094,918
regex (-11 [-0.2%]) 6,926 4,165,432 166,449,586 10,598 3,349,024 230,129,839
ecrecover (+50 [+3.7%]) 1,392 137,283 8,179,549 10,502 2,934,914 242,451,548
pairing (-14 [-0.3%]) 4,005 1,862,964 102,530,853 5,269 2,010,483 134,816,207
fib_e2e 17,348 12,000,277 404,296,287 17,128 7,596,379 434,396,860
kitchen_sink 15,317 154,595 903,326,712 23,907 7,991,164 755,626,485

Commit: 022cb4a

Benchmark Workflow

@stephenh-axiom-xyz stephenh-axiom-xyz merged commit a6be3df into feat/new-execution Jul 11, 2025
35 of 36 checks passed
@stephenh-axiom-xyz stephenh-axiom-xyz deleted the feat/remove-single-segment-e2 branch July 11, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants