Skip to content

feat(new-execution): optimize algebra extension e1/e2 execution#1882

Merged
shuklaayush merged 1 commit into
feat/new-executionfrom
feat/new-exec-optimize-algebra-ext
Jul 24, 2025
Merged

feat(new-execution): optimize algebra extension e1/e2 execution#1882
shuklaayush merged 1 commit into
feat/new-executionfrom
feat/new-exec-optimize-algebra-ext

Conversation

@shuklaayush

@shuklaayush shuklaayush commented Jul 18, 2025

Copy link
Copy Markdown
Collaborator
  • use hardcoded functions for common fields
  • replace get_curve_type_from_modulus used in hardcoded ec addition with get_field_type

Reth benchmark (block 21000000) ~2-3% improvement
Reth benchmark (block 21431353) ~5-10% improvement (has 16 ecPairing operations)

@github-actions

This comment has been minimized.

@codspeed-hq

codspeed-hq Bot commented Jul 18, 2025

Copy link
Copy Markdown

CodSpeed WallTime Performance Report

Merging #1882 will degrade performances by 27.15%

Comparing feat/new-exec-optimize-algebra-ext (c8fbbf3) with feat/new-execution (b269dbb)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark_execute[pairing] 296.2 ms 226.1 ms +31.01%
benchmark_execute[quicksort] 41.4 ms 56.9 ms -27.15%
benchmark_execute_metered[pairing] 315.6 ms 246.8 ms +27.89%

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@shuklaayush shuklaayush force-pushed the feat/new-exec-optimize-algebra-ext branch from f3386f2 to da87673 Compare July 18, 2025 22:43
@github-actions

This comment has been minimized.

@shuklaayush shuklaayush marked this pull request as ready for review July 23, 2025 14:20
@github-actions

This comment has been minimized.

@jonathanpwang jonathanpwang force-pushed the feat/new-exec-device branch from 5672570 to 91175c6 Compare July 23, 2025 15:40
Base automatically changed from feat/new-exec-device to feat/new-execution July 24, 2025 03:48
fix: combine fp2 and modular step

refactor: reduce duplication

feat: add more fields and use macro

fix: k256 field decoding

fix: proper opcode decoding and setup

fix: return option<op>

fix: setup assert

fix: secp fp, fq; smh

fix(temp): comment out scalar fields temporarily

fix: separate fp2 handling

fix: reduce to canonical before reading

chore: cargo fmt
@shuklaayush shuklaayush force-pushed the feat/new-exec-optimize-algebra-ext branch from ea5f732 to c8fbbf3 Compare July 24, 2025 13:55
@github-actions

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair 1,078 322,700 17,672,408 - - -
fibonacci (+15 [+0.7%]) 2,233 3,000,556 51,508,517 - - -
regex (-70 [-0.9%]) 7,523 8,330,866 165,431,684 - - -
ecrecover (-4 [-0.3%]) 1,148 274,568 8,596,011 - - -
pairing (+61 [+1.6%]) 3,765 3,725,930 93,105,233 - - -

Commit: c8fbbf3

Benchmark Workflow

@shuklaayush shuklaayush merged commit af8f6c9 into feat/new-execution Jul 24, 2025
30 of 31 checks passed
@shuklaayush shuklaayush deleted the feat/new-exec-optimize-algebra-ext branch July 24, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants