feat(new-execution): optimize algebra extension e1/e2 execution#1882
Merged
shuklaayush merged 1 commit intoJul 24, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
CodSpeed WallTime Performance ReportMerging #1882 will degrade performances by 27.15%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | benchmark_execute[pairing] |
296.2 ms | 226.1 ms | +31.01% |
| ❌ | benchmark_execute[quicksort] |
41.4 ms | 56.9 ms | -27.15% |
| ⚡ | benchmark_execute_metered[pairing] |
315.6 ms | 246.8 ms | +27.89% |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f3386f2 to
da87673
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5672570 to
91175c6
Compare
fix: combine fp2 and modular step refactor: reduce duplication feat: add more fields and use macro fix: k256 field decoding fix: proper opcode decoding and setup fix: return option<op> fix: setup assert fix: secp fp, fq; smh fix(temp): comment out scalar fields temporarily fix: separate fp2 handling fix: reduce to canonical before reading chore: cargo fmt
ea5f732 to
c8fbbf3
Compare
Commit: c8fbbf3 |
nyunyunyunyu
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_curve_type_from_modulusused in hardcoded ec addition withget_field_typeReth benchmark (block 21000000) ~2-3% improvement
Reth benchmark (block 21431353) ~5-10% improvement (has 16 ecPairing operations)