chore: Optimistic E3 Execution for Poseidon2 Chip#1896
Merged
Conversation
a23551d to
748a8ca
Compare
CodSpeed WallTime Performance ReportMerging #1896 will not alter performanceComparing
|
This comment has been minimized.
This comment has been minimized.
748a8ca to
9d4a757
Compare
9d4a757 to
23a62c0
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
Please provide an update on the measured time in insn/s of just verifybatch before and after this PR |
23a62c0 to
7012a63
Compare
This comment has been minimized.
This comment has been minimized.
7012a63 to
c74c624
Compare
c74c624 to
b98c4a3
Compare
Commit: b98c4a3 |
| let mut row_idx = 0; | ||
| let mut row_slice = trace.values.as_mut_slice(); | ||
| let mut chunk_start = Vec::new(); | ||
| while row_idx < rows_used { |
Contributor
There was a problem hiding this comment.
maybe you could have used RecordSeeker for this, not sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a flag to execute E3 optimistically. When the flag is enabled,
verify_batchskips all verification logic and postpone all poseidon2 hash computation to the tracegen phase.Reth-benchmark shows 20% execution time reduction. Tracegen time slightly increases but the increment is less than the saving.
Close INT-4374
Per opcode stats on my laptop(variance is large but we could see a significant difference):
Before:
After: