Skip to content

chore(perf): use constant for address space in tracing_read when possible#1899

Merged
jonathanpwang merged 2 commits into
feat/new-executionfrom
INT-4037
Jul 25, 2025
Merged

chore(perf): use constant for address space in tracing_read when possible#1899
jonathanpwang merged 2 commits into
feat/new-executionfrom
INT-4037

Conversation

@jonathanpwang

@jonathanpwang jonathanpwang commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

I went through the uses of tracing_read and switched to using constants for better compilation optimization whenever possible, where the requirements on the address space were determined according to ISA.md

I don't think there was really a performance diff: https://github.com/axiom-crypto/openvm-reth-benchmark/actions/runs/16513213487

@github-actions

This comment has been minimized.

@jonathanpwang jonathanpwang changed the title perf: use constant for address space in tracing_read when possible chore(perf): use constant for address space in tracing_read when possible Jul 25, 2025
@codspeed-hq

codspeed-hq Bot commented Jul 25, 2025

Copy link
Copy Markdown

CodSpeed WallTime Performance Report

Merging #1899 will not alter performance

Comparing INT-4037 (919ea91) with feat/new-execution (a35aa57)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 24 untouched benchmarks

@shuklaayush shuklaayush left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from INT-4466 to feat/new-execution July 25, 2025 14:31
@github-actions

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-59 [-5.5%]) 1,018 322,700 17,672,408 - - -
fibonacci (+7 [+0.3%]) 2,223 3,000,556 51,508,517 - - -
regex (-23 [-0.3%]) 7,533 8,330,866 165,431,684 - - -
ecrecover (-4 [-0.4%]) 1,118 274,568 8,596,011 - - -
pairing (+94 [+2.6%]) 3,729 3,725,930 93,105,233 - - -

Commit: 919ea91

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit fb9007d into feat/new-execution Jul 25, 2025
34 checks passed
@jonathanpwang jonathanpwang deleted the INT-4037 branch July 25, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants