Skip to content

chore: make SdkVmConfig::to_inner pub#1906

Merged
jonathanpwang merged 1 commit into
feat/new-executionfrom
chore/sdk-pub
Jul 26, 2025
Merged

chore: make SdkVmConfig::to_inner pub#1906
jonathanpwang merged 1 commit into
feat/new-executionfrom
chore/sdk-pub

Conversation

@jonathanpwang

Copy link
Copy Markdown
Contributor

SdkVmConfigInner is the more natural struct to work with, SdkVmConfig is just for serialization convenience.

`SdkVmConfigInner` is the more natural struct to work with,
`SdkVmConfig` is just for serialization convenience.
@jonathanpwang jonathanpwang merged commit a62e015 into feat/new-execution Jul 26, 2025
8 checks passed
@jonathanpwang jonathanpwang deleted the chore/sdk-pub branch July 26, 2025 22:32
@codspeed-hq

codspeed-hq Bot commented Jul 26, 2025

Copy link
Copy Markdown

CodSpeed WallTime Performance Report

Merging #1906 will not alter performance

Comparing chore/sdk-pub (4a133b7) with feat/new-execution (b788e45)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 24 untouched benchmarks

@github-actions

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-58 [-5.1%]) 1,076 322,701 17,672,420 - - -
fibonacci (-42 [-1.9%]) 2,206 3,000,556 51,508,517 - - -
regex (-14 [-0.2%]) 7,477 8,330,866 165,431,684 - - -
ecrecover (+6 [+0.5%]) 1,167 274,568 8,596,011 - - -
pairing (-21 [-0.6%]) 3,677 3,725,930 93,105,233 - - -

Commit: 4a133b7

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant