fix: reduce threads per block for FRI tracegen launcher#2124
Merged
Conversation
Commit: 0002889 |
jonathanpwang
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves INT-4950.
Some CUDA 13.0 optimizer choices caused kernel
fri_reduced_opening_tracegento use 80 registers (previously 58), causing the total number of registers per block to exceed the allowable amount set by the device.Benchmark difference on CUDA 12.9 is negligible. Benchmarks done to determine savings gained by switching to CUDA 13.0 will be done later.