fix: ensure segments are below thresholds#2138
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
9c55ffc to
88ea52e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
21cb0ff to
7fe4ed2
Compare
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
approved these changes
Sep 16, 2025
nyunyunyunyu
left a comment
Contributor
There was a problem hiding this comment.
LGTM. This's more decent than subtracting DEFAULT_MAX_TRACE_HEIGHT with a random number.
jonathanpwang
approved these changes
Sep 16, 2025
jonathanpwang
left a comment
Contributor
There was a problem hiding this comment.
Actual implementation is ok, but you should leave comments explaining the rational about when to use padded versus unpadded and the considerations that went into it
This comment has been minimized.
This comment has been minimized.
Commit: d0480da |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the optimistic execution/segmentation with a checkpointing approach that checkpoints the last
trace_height/instretvalue that is below the thresholds and use these values for the segments. This should make the segmentation more predictable for downstream usage since the segments should satisfy the thresholds (with the only caveat being if segmentation happens when there is no checkpoint to fall back to i.e. if we overshoot the threshold before the first segmentation check)This requires storing some extra state and results in a higher segment count compared to earlier for the same thresholds. Also makes execution slightly slower since we're doing some extra work now
benchmark run with 0.7B max cells
benchmark run with 1.2B max cells