fix: Over-align public constants in moduli_init#2150
Merged
Conversation
93036aa to
31017a0
Compare
This comment has been minimized.
This comment has been minimized.
jonathanpwang
approved these changes
Sep 26, 2025
jonathanpwang
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but hold on merging.
limb_list_borders doesn't need alignment because (1) it's usize aligned, (2) we only access it's fields statically so it likely is compiled away already.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1607d17 to
1ae4417
Compare
Commit: 1ae4417 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
two_modular_limbs_listconstant declared bymoduli_init!and used later in the complex setup macro was not guaranteed to be aligned to a large enough alignment. This caused an issue in some use-case.This change aligns the public constant
two_modular_limbs_listto the max block size of a modulus among all moduli declared to ensure no memory alignment issues arise.Fixes INT-5135