feat(cuda): VPMM v3 and async app prover#2165
Merged
Merged
Conversation
Adds `AsyncAppProver` which executes metered serially and then re-executes while spawning prover tasks for each continuation segment. The prover tasks use a semaphore to limit the max concurrency. Note this PR includes the fix #2155 --------- Co-authored-by: Ayush Shukla <ayush@axiom.xyz>
This comment has been minimized.
This comment has been minimized.
Contributor
|
I merged #2153 into this branch; we can close the latter after testing is done |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jonathanpwang
approved these changes
Oct 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds VPMM v3 support and implements an asynchronous app prover for improved concurrent proof generation. The changes focus on enabling async proof generation capabilities, adding concurrency controls for execution suspension, and updating dependencies.
- Introduces AsyncAppProver for thread-safe concurrent proof generation
- Adds execution suspension logic via
should_suspendcontext checks - Updates stark backend dependencies to v1.2.1-rc.6 and adds async test infrastructure
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/sdk/src/prover/app.rs | Implements AsyncAppProver with semaphore-based concurrency control |
| crates/vm/src/arch/interpreter.rs | Adds suspension logic to TCO execution path |
| extensions/keccak256/circuit/src/tests.rs | Adds multi-threaded async test for CUDA tracegen |
| Cargo.toml | Updates stark backend dependencies to rc.6 and adds tokio workspace dependency |
| crates/sdk/Cargo.toml | Adds async feature with tokio dependency |
| benchmarks/prove/Cargo.toml | Updates clap/tokio to workspace versions and adds async feature |
| .github/workflows/ | Updates CI configuration for async testing and Foundry version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This comment has been minimized.
This comment has been minimized.
Currently the invalid memory access is never used, but it's still better to address it so `compute-analyzer` does not complain.
Commit: 0ca84f8 |
Maillew
pushed a commit
that referenced
this pull request
Oct 22, 2025
Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com> Co-authored-by: Ayush Shukla <ayush@axiom.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.