Skip to content

feat(cuda): VPMM v3 and async app prover#2165

Merged
jonathanpwang merged 19 commits into
mainfrom
chore/vpmm_v3
Oct 16, 2025
Merged

feat(cuda): VPMM v3 and async app prover#2165
jonathanpwang merged 19 commits into
mainfrom
chore/vpmm_v3

Conversation

@gaxiom

@gaxiom gaxiom commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

No description provided.

gaxiom and others added 11 commits October 2, 2025 17:31
Adds `AsyncAppProver` which executes metered serially and then
re-executes while spawning prover tasks for each continuation segment.
The prover tasks use a semaphore to limit the max concurrency.

Note this PR includes the fix
#2155

---------

Co-authored-by: Ayush Shukla <ayush@axiom.xyz>
@github-actions

This comment has been minimized.

@jonathanpwang

Copy link
Copy Markdown
Contributor

I merged #2153 into this branch; we can close the latter after testing is done

@jonathanpwang jonathanpwang changed the title chore(cuda): test VPMM v3 feat(cuda): VPMM v3 and async app prover Oct 14, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jonathanpwang jonathanpwang marked this pull request as ready for review October 15, 2025 21:45
Copilot AI review requested due to automatic review settings October 15, 2025 21:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds VPMM v3 support and implements an asynchronous app prover for improved concurrent proof generation. The changes focus on enabling async proof generation capabilities, adding concurrency controls for execution suspension, and updating dependencies.

  • Introduces AsyncAppProver for thread-safe concurrent proof generation
  • Adds execution suspension logic via should_suspend context checks
  • Updates stark backend dependencies to v1.2.1-rc.6 and adds async test infrastructure

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
crates/sdk/src/prover/app.rs Implements AsyncAppProver with semaphore-based concurrency control
crates/vm/src/arch/interpreter.rs Adds suspension logic to TCO execution path
extensions/keccak256/circuit/src/tests.rs Adds multi-threaded async test for CUDA tracegen
Cargo.toml Updates stark backend dependencies to rc.6 and adds tokio workspace dependency
crates/sdk/Cargo.toml Adds async feature with tokio dependency
benchmarks/prove/Cargo.toml Updates clap/tokio to workspace versions and adds async feature
.github/workflows/ Updates CI configuration for async testing and Foundry version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread crates/sdk/src/prover/app.rs
Comment thread extensions/keccak256/circuit/src/tests.rs
Comment thread extensions/keccak256/circuit/src/tests.rs
Comment thread extensions/keccak256/circuit/src/tests.rs
Comment thread crates/sdk/src/prover/app.rs
@github-actions

This comment has been minimized.

Currently the invalid memory access is never used, but it's still better
to address it so `compute-analyzer` does not complain.
@github-actions

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+35 [+15.6%]) 259 322,610 2,058,654 - - -
fibonacci (-6 [-0.6%]) 1,007 1,500,209 2,100,402 - - -
regex (+5 [+0.2%]) 2,328 4,137,502 17,695,216 - - -
ecrecover (-8 [-1.1%]) 703 122,859 2,262,718 - - -
pairing (+9 [+0.6%]) 1,453 1,745,742 25,468,210 - - -

Commit: 0ca84f8

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit 8141dac into main Oct 16, 2025
45 checks passed
@jonathanpwang jonathanpwang deleted the chore/vpmm_v3 branch October 16, 2025 02:20
Maillew pushed a commit that referenced this pull request Oct 22, 2025
Co-authored-by: Jonathan Wang <31040440+jonathanpwang@users.noreply.github.com>
Co-authored-by: Ayush Shukla <ayush@axiom.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants