feat(cli): add SegmentationArgs to prove command#2178
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable segmentation parameters to the prove command in the CLI, allowing users to customize trace height and cell limits for proof generation. The default segmentation limits have also been reduced for more conservative resource usage.
Key changes:
- Reduced default segmentation limits (
DEFAULT_MAX_TRACE_HEIGHTfrom 2^23 to 2^22,DEFAULT_MAX_CELLSfrom 2B to 1.2B) - Added
SegmentationArgsstruct with CLI arguments forsegment_max_heightandsegment_max_cells - Integrated segmentation arguments into all three proof generation subcommands (App, Stark, Evm)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/vm/src/arch/execution_mode/metered/segment_ctx.rs | Reduced default segmentation limits for trace height and cells |
| crates/cli/src/commands/prove.rs | Added SegmentationArgs struct and integrated it into prove subcommands with helper functions |
| benchmarks/prove/src/util.rs | Updated comment to clarify segment_max_cells refers to total cells across all chips |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
shuklaayush
approved these changes
Oct 24, 2025
This comment has been minimized.
This comment has been minimized.
0884791 to
0aee951
Compare
Commit: 0aee951 |
Maillew
pushed a commit
that referenced
this pull request
Nov 5, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Maillew
pushed a commit
that referenced
this pull request
Nov 5, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.