chore(test): add GpuChipTestBuilder::new_persistent#2191
Merged
jonathanpwang merged 2 commits intoDec 7, 2025
Merged
Conversation
Contributor
|
Not sure why we want this? It doesn't simplify any code |
Contributor
Author
|
Fair point. After thinking it through, for a while I've refactored to add |
jonathanpwang
approved these changes
Nov 13, 2025
jonathanpwang
changed the title
GpuChipTestBuilder::new_persistent
Contributor
Author
|
Hi @jonathanpwang ! Should I fix CI's? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
OPENVM_GPU_TEST_PERSISTENTenv var support toGpuChipTestBuilder::new().Defaults to volatile memory for backward compatibility. Set to
1to enable persistent mode.