Skip to content

fix: use branch of halo2curves without nostack#2252

Merged
jonathanpwang merged 7 commits into
feat/aotfrom
fix/aot-asm
Nov 17, 2025
Merged

fix: use branch of halo2curves without nostack#2252
jonathanpwang merged 7 commits into
feat/aotfrom
fix/aot-asm

Conversation

@yi-sun

@yi-sun yi-sun commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

This comment has been minimized.

@codspeed-hq

codspeed-hq Bot commented Nov 16, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #2252 will improve performances by 21.52%

Comparing fix/aot-asm (ceb7507) with feat/aot (0cbc78c)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 2 improvements
✅ 22 untouched
⏩ 36 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
WallTime benchmark_execute[revm_snailtracer] 8.6 ms 7.1 ms +21.52%
WallTime benchmark_execute_metered[revm_snailtracer] 8.2 ms 7.3 ms +12.46%

Footnotes

  1. 36 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair 222 322,658 2,058,654 - - -
fibonacci 964 1,500,209 2,100,402 - - -
regex 2,404 4,137,502 17,695,216 - - -
ecrecover 699 122,859 2,265,100 - - -
pairing 1,480 1,745,742 25,468,210 - - -

Commit: ceb7507

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit 47f0e0a into feat/aot Nov 17, 2025
71 of 73 checks passed
@jonathanpwang jonathanpwang deleted the fix/aot-asm branch November 17, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants