Skip to content

fix: lazy_update_boundary_heights needs to handle uninitialized memory#2286

Merged
jonathanpwang merged 3 commits into
mainfrom
fix/access-adapter-large-init
Nov 30, 2025
Merged

fix: lazy_update_boundary_heights needs to handle uninitialized memory#2286
jonathanpwang merged 3 commits into
mainfrom
fix/access-adapter-large-init

Conversation

@jonathanpwang

@jonathanpwang jonathanpwang commented Nov 30, 2025

Copy link
Copy Markdown
Contributor

towards INT-5617

The metering update did not account for the initial 8->4 split from handle_uninitialized_memory

Copilot AI review requested due to automatic review settings November 30, 2025 03:10
@jonathanpwang jonathanpwang force-pushed the fix/access-adapter-large-init branch from a1e4711 to 3a4b51f Compare November 30, 2025 03:10

This comment was marked as outdated.

@github-actions

This comment has been minimized.

Comment thread crates/vm/src/arch/execution_mode/metered/memory_ctx.rs Outdated
nyunyunyunyu

This comment was marked as resolved.

@github-actions

This comment has been minimized.

@jonathanpwang jonathanpwang force-pushed the fix/access-adapter-large-init branch from 42f0e0d to a35cd12 Compare November 30, 2025 18:11
@jonathanpwang jonathanpwang changed the title fix: lazy_update_boundary_heights needs to handle large initial accesses fix: lazy_update_boundary_heights needs to handle uninitialized memory Nov 30, 2025
@github-actions

Copy link
Copy Markdown
group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-15 [-6.1%]) 232 322,610 2,058,654 - - -
fibonacci (+2 [+0.2%]) 1,001 1,500,209 2,100,402 - - -
regex (-45 [-1.9%]) 2,337 4,137,502 17,695,216 - - -
ecrecover (-54 [-7.1%]) 705 122,859 2,263,998 - - -
pairing (+52 [+3.7%]) 1,465 1,745,742 (-59908 [-0.2%]) 25,408,302 - - -

Commit: a35cd12

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit b0a4b89 into main Nov 30, 2025
80 of 89 checks passed
@jonathanpwang jonathanpwang deleted the fix/access-adapter-large-init branch November 30, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants