Skip to content

gh-58032: Deprecate the argparse.FileType type converter#124664

Merged
serhiy-storchaka merged 9 commits into
python:mainfrom
serhiy-storchaka:argparse-filetype-deprecate
Oct 23, 2024
Merged

gh-58032: Deprecate the argparse.FileType type converter#124664
serhiy-storchaka merged 9 commits into
python:mainfrom
serhiy-storchaka:argparse-filetype-deprecate

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 27, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Sep 27, 2024
Closed
Mariatta
Mariatta reviewed Sep 27, 2024
View reviewed changes
Comment thread Lib/argparse.py Outdated
@serhiy-storchaka @Mariatta
Update Lib/argparse.py
1eaeebf 
Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
@Mariatta

Mariatta commented Sep 27, 2024

Copy link
Copy Markdown
Member

Should we add this to the pending-removal-in-future.rst?

savannahostrowski
savannahostrowski reviewed Oct 11, 2024
View reviewed changes
Comment thread Lib/test/test_argparse.py Outdated
@savannahostrowski savannahostrowski linked an issue Oct 18, 2024 that may be closed by this pull request
argparse.FileType opens a file and never closes it #58032
Closed
@serhiy-storchaka

serhiy-storchaka commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

@Mariatta, could you please look again at this PR?

@serhiy-storchaka serhiy-storchaka merged commit 834ba5a into python:main Oct 23, 2024
@serhiy-storchaka serhiy-storchaka deleted the argparse-filetype-deprecate branch October 23, 2024 07:50
@hugovk hugovk mentioned this pull request Oct 23, 2024
Merged
@hugovk

hugovk commented Oct 23, 2024

Copy link
Copy Markdown
Member

Please see #125871 as a small docs update.

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@serhiy-storchaka @ebonnal
pythongh-58032: Deprecate the argparse.FileType type converter (pytho…
5376434 
…nGH-124664)
adamchainz added a commit to adamchainz/heroicons that referenced this pull request Aug 5, 2025
@adamchainz
Rewrite CLI without argparse.FileType
22e190f 
It's deprecated in Python 3.14: python/cpython#124664
@adamchainz adamchainz mentioned this pull request Aug 5, 2025
Merged
adamchainz added a commit to adamchainz/heroicons that referenced this pull request Aug 5, 2025
@adamchainz
Rewrite CLI without argparse.FileType (#332)
6840177 
It's deprecated in Python 3.14:
python/cpython#124664
@StanFromIreland

StanFromIreland commented Jun 21, 2026

Copy link
Copy Markdown
Member

I'm a little late to the party, but I don't understand why PendingDeprecationWarning was used here. The docs, and warning message contradict the exception saying it is deprecated? Can it be updated to DeprecationWarning if it is deprecated, otherwise I think we should remove the .. deprecated:: and rephrase the warning messages.

@serhiy-storchaka

serhiy-storchaka commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

We use the deprecated directive even if there is no warning at runtime (they can be added latter). This differs from soft-deprecated where we do not plan runtime warning or deletion.

@StanFromIreland

StanFromIreland commented Jun 21, 2026

Copy link
Copy Markdown
Member

Yes, but I still don't understand why we're using PendingDeprecationWarning instead of DeprecationWarning here if it is deprecated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta left review comments
@savannahostrowski savannahostrowski savannahostrowski left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

argparse.FileType opens a file and never closes it

5 participants

@serhiy-storchaka @Mariatta @hugovk @StanFromIreland @savannahostrowski