fix: Apply theme style to embedded diagram#7903
Merged
Merged
Conversation
When diagrams are created with "adaptive colors" they automatically change to light-/darkmode depending on the browser preference. This leads to rendering problems when the settings in the browser differ from the wiki.js theme setting. Fixes requarks#7677
tribut
force-pushed
the
fix-drawio-darkmode
branch
from
48bec1b to
65ee434
Compare
Refactor SVG color scheme handling in diagram class.
Removed unnecessary direction property from first SVG in diagram.
NGPixel
approved these changes
Jan 20, 2026
Member
|
Thanks! |
Contributor
Author
|
Thanks for merging, but With your changes, it will still automatically switch to dark mode if the browser has that preference set. |
Contributor
Author
|
I've created #7905 so I don't forget and it doesn't get buried in a closed PR. Again, thank you for your continued dedication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When diagrams are created with "adaptive colors" they automatically change to light-/darkmode depending on the browser preference. This leads to rendering problems when the settings in the browser differ from the wiki.js theme setting.
Fixes #7677