🐛 Restore original superglobals after Request::capture()#525
Merged
retlehs merged 1 commit intoMar 23, 2026
Merged
Conversation
Instead of re-running wp_magic_quotes() after capturing the Laravel request, save and restore the exact original superglobals. This preserves the #408 fix (clean request data in Laravel) while avoiding subtle re-slash drift for payloads with pre-existing escape sequences. Refs #524 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
QWp6t
approved these changes
Mar 23, 2026
retlehs
deleted the
fix/restore-original-superglobals-after-request-capture
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wp_magic_quotes()afterRequest::capture()could produce subtlydifferent slashing for payloads with pre-existing escape sequences
(e.g. JSON strings)
the exact original superglobals verbatim
Requestobject still gets clean (unslashed) data, preservingthe The captured request data is slashed because of the insanity that is wp_magic_quotes() #408 fix
Closes #524