Retry Jupyter proxy requests after token refresh#1101
Merged
Conversation
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
e10cd26 to
09c13f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${RUNME_CONFIG_DIR}/jupyter/*.jsonbefore retryingRoot Cause
The Jupyter proxy cached server records in memory and only reloaded them on cache misses. After a local Jupyter server restarted on the same port, the on-disk token changed, but existing cached records kept forwarding the old token and Jupyter returned 403.
Fixes runmedev/web#164
Validation
go test ./pkg/agent/servergo test ./pkg/agent/server -run TestForwardHTTP_ReloadsTokenAfterForbidden -count=1git diff --checkrunme run lint testpassed lint, but full tests are blocked locally by missing integration dependencies (deno,direnv,tree, Dagger Shelldigest) and shell-initznoise in PTY testsmake test-dockerwas attempted as the documented fallback, but the configured remote Docker context certificate is expired and local Docker Desktop is not running