Fix jsonschema.json ignore not taking effect given positional arguments#768
Conversation
…uments Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR fixes configuration-defined ignore/extension behavior not taking effect when inputs are provided as positional arguments. Changes:
Technical Notes: Extension matching for directory recursion now becomes configuration-aware for positional inputs when the configuration file is unambiguous. 🤖 Was this summary useful? React with 👍 or 👎 |
| const auto extensions{parse_extensions(options, std::nullopt)}; | ||
| std::optional<sourcemeta::blaze::Configuration> shared_configuration{ | ||
| std::nullopt}; | ||
| if (seen_configurations.size() == 1) { |
There was a problem hiding this comment.
When positional arguments resolve to multiple different jsonschema.json files, merge_configuration_ignore merges ignore rules from all of them but parse_extensions will fall back to std::nullopt (so per-directory configured extension filtering won’t apply for directory traversal). Is that behavior intended, or should extension configuration also be applied when multiple configurations are in play?
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
There was a problem hiding this comment.
1 issue found across 28 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Signed-off-by: Juan Cruz Viotti jv@jviotti.com