Skip to content

Disallow recursive resolve map resolution on jsonschema.json#773

Merged
jviotti merged 1 commit into
mainfrom
no-cyclic-resolve
Jun 9, 2026
Merged

Disallow recursive resolve map resolution on jsonschema.json#773
jviotti merged 1 commit into
mainfrom
no-cyclic-resolve

Conversation

@jviotti

@jviotti jviotti commented Jun 9, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Jun 9, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR changes jsonschema.json URI remapping so resolve entries are applied only once (non-transitively), preventing recursive/chain resolution.

Changes:

  • Updated `CustomResolver` to remap an identifier to a single final `target` without recursively invoking the resolver again
  • Adjusted debug logging to reflect the single-step remap behavior
  • Updated documentation to clarify that `resolve` lookups are non-transitive
  • Refreshed existing tests to use a single direct remap rather than chained remaps
  • Added a new validation test ensuring chained remaps fail under the new non-transitive semantics

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Re-trigger cubic

@jviotti jviotti merged commit 45475bb into main Jun 9, 2026
15 checks passed
@jviotti jviotti deleted the no-cyclic-resolve branch June 9, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant