Skip to content

Support URI references in --default-dialect#774

Merged
jviotti merged 3 commits into
mainfrom
default-dialect-relative
Jun 10, 2026
Merged

Support URI references in --default-dialect#774
jviotti merged 3 commits into
mainfrom
default-dialect-relative

Conversation

@jviotti

@jviotti jviotti commented Jun 10, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti marked this pull request as ready for review June 10, 2026 12:30
@augmentcode

augmentcode Bot commented Jun 10, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR extends default-dialect handling to support relative URI/path references, primarily to make --default-dialect and defaultDialect in jsonschema.json usable with local meta-schemas.

Changes:

  • Documented that defaultDialect may be an absolute URI or a relative path resolved against the configuration directory, and that --default-dialect resolves relative to the current working directory.
  • Introduced resolve_relative_uri to convert relative URI/path inputs into canonical file:// URIs.
  • Reused the same relative-resolution helper for configuration resolve map targets.
  • Updated default_dialect() to return a resolved string value (instead of a view) to accommodate computed URIs.
  • Added a validate test for CLI relative default dialect resolution.
  • Added an inspect test verifying that a relative (and path-normalized) defaultDialect in config becomes a canonical file:// URI.

Technical Notes: Relative inputs are normalized via weakly_canonical before being converted to a file:// URI.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/utils.h
Comment thread src/utils.h

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Re-trigger cubic

jviotti added 2 commits June 10, 2026 08:46
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 43506e6 into main Jun 10, 2026
15 checks passed
@jviotti jviotti deleted the default-dialect-relative branch June 10, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant