env: use execvp instead of Command::status on Unix systems#8365
Merged
Conversation
|
GNU testsuite comparison: |
aleasto
reviewed
Jul 21, 2025
cakebaker
reviewed
Jul 22, 2025
cakebaker
left a comment
cakebaker
left a comment
Contributor
There was a problem hiding this comment.
clippy complains about two unneeded return statements on Windows, otherwise it looks good.
Contributor
Author
Addressed. |
cakebaker
approved these changes
Jul 22, 2025
Contributor
|
Thanks! |
Collaborator
|
@yuankunzhang can you please have a look at #9614 , it uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8361.