refactor!: avoid forced style recalculations on app-layout resize#11493
Merged
Conversation
Replace the combination of window resize listener and separate ResizeObserver with a single unified ResizeObserver that handles all layout recalculation: overlay mode, touch-optimized mode, drawer size, and offset sizes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Extract the unobserve/observe pattern into a __scheduleResize method and coalesce multiple __onResize callbacks using cancelAnimationFrame. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vursen
changed the title
vursen
changed the title
vursen
changed the title
vursen
force-pushed
the
refactor/app-layout-resize-observer
branch
from
af5886a to
284749a
Compare
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vursen
force-pushed
the
refactor/app-layout-resize-observer
branch
from
a85c608 to
a2df77e
Compare
|
sissbruecker
approved these changes
Apr 20, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-alpha3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR consolidates a window resize listener and a separate
ResizeObserverinto a singleResizeObserverthat reads values in the observer callback while DOM updates are deferred torequestAnimationFrame. This helps avoid forced style recalculations on app layout resize.The screenshots show resizing the Starpass app before and after with 4x CPU throttle.
Warning
There is a small risk of this being a breaking change, as it it alters the timing of when attributes are set.
Type of change